Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction for completion #93

Merged
merged 3 commits into from
Sep 2, 2018
Merged

Add instruction for completion #93

merged 3 commits into from
Sep 2, 2018

Conversation

willbasky
Copy link
Contributor

@willbasky willbasky commented Sep 1, 2018

This change is Reviewable

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @willbasky)


CHANGELOG.md, line 11 at r1 (raw file):

- Track issue content
- Add wiki notes
- Add completion instruction

Add completion installation instruction


README.md, line 33 at r1 (raw file):

### Completion for commands and options (tested on Ubuntu 18.04)

    ff --bash-completion-script `which ff` | sudo tee /etc/bash_completion.d/ff

Добавь "MacOS with brew" — каталог /usr/local/etc/bash_completion.d/

@willbasky
Copy link
Contributor Author

willbasky commented Sep 1, 2018

Добавь "MacOS with brew" — каталог /usr/local/etc/bash_completion.d/

ff --bash-completion-script which ff | sudo tee /usr/local/etc/bash_completion.d/ff

??

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @willbasky)


README.md, line 39 at r2 (raw file):

#### MacOS

    ff --bash-completion-script which ff | sudo tee /usr/local/etc/bash_completion.d/ff

кавычки пропустил

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r3.
Reviewable status: 2 of 4 files reviewed, all discussions resolved

Copy link
Member

@cblp cblp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@cblp cblp merged commit 7cfa787 into ff-notes:master Sep 2, 2018
@willbasky willbasky deleted the willbasky/6-add-shell-completion branch September 2, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants