Fix again

fflorent · Jan 11, 2025 · 0dfc8f4 · 0dfc8f4
1 parent 39f2479
commit 0dfc8f4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/app/gen-server/lib/homedb/GroupsManager.ts b/app/gen-server/lib/homedb/GroupsManager.ts
@@ -218,8 +218,10 @@ export class GroupsManager {
     this.defaultGroups.forEach(groupProps => {
       if (!groupProps.orgOnly || !inherit) {
         // Skip this group if it's an org only group and the resource inherits from a parent.
-        const group = new Group();
-        group.name = groupProps.name;
+        const group = Group.create({
+          name: groupProps.name,
+          type: Group.ROLE_TYPE,
+        });
         if (inherit) {
           this.setInheritance(group, inherit);
         }

diff --git a/test/gen-server/lib/homedb/UsersManager.ts b/test/gen-server/lib/homedb/UsersManager.ts
@@ -149,13 +149,12 @@ describe('UsersManager', function () {
         const entries = Object.entries(groupDefinition) as [NonGuestGroup['name'], User[] | undefined][];
 
         return entries.map(([groupName, users], index) => {
-          const group = new Group() as NonGuestGroup;
-          group.id = index;
-          group.name = groupName;
-          if (users) {
-            group.memberUsers = users;
-          }
-          return group;
+          return Group.create({
+            id: index,
+            name: groupName,
+            type: Group.ROLE_TYPE,
+            memberUsers: users,
+          }) as NonGuestGroup;
         });
       }