Add first version of time-constrained ORC-WER (tcORC-WER) #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boeddeker
reviewed
Jan 29, 2024
| # Add a segment index to the reference so that we can later find words that | ||
| # come from the same segment | ||
| for i, s in enumerate(reference): | ||
| s['segment_index'] = i |
There was a problem hiding this comment.
Hmm. Should the assignment be before the filter?
There was a problem hiding this comment.
It shouldn't make a difference because the segment index is here just used for grouping and not for sorting. But it could be easier to understand what's happening when moved before the filter operation
There was a problem hiding this comment.
Hmm. The filter will remove empty segments. So the assignment will not be valid for the input of this function.
Should the assignment also consider the empty segments? Or do we drop the empty segments in the apply assignment function?
We could add this to a ToDo list and solve this later. For the challenge start it is not important.
boeddeker
reviewed
Jan 29, 2024
boeddeker
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to compute the tcORC-WER.
Example:
The current version is tested on Libri-CSS with a system that produces 8 streams. It finished computation within 10 minutes and used less than 2GB of RAM (which is a huge improvement over ORC-WER!). These requirements should drop further when the number of streams is smaller.
The code is not fully optimized yet and contains many TODOs. I'll work on some of these TODOs and update the PR during the next few days.
I'll merge main back into this PR once #50 is merged.