Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to only evaluate single-speaker regions #64

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

thequilo
Copy link
Member

Adresses #62. The name is still up for discussion.

command_parser.add_argument(
'-1', '--exclude-overlap',
action='store_true',
help='Limits scoring to single-speaker regions. '
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TCord Could you add a sentence, where the user should be careful? Or was that only relevant, if you want to calculate the overlap only DER?

@boeddeker
Copy link
Member

I vote for--regions [all|single|overlap|nonoverlap] instead of adding a new option that is not used in any existing framework.
It is already used in spyder and works for md-eval, dscore, pyannote and spyder.

@thequilo
Copy link
Member Author

I also like --regions, but md-eval only supports --regions [all|nooverlap]. Also, should we name it --score-regions?

@boeddeker
Copy link
Member

I also like --regions, .... Also, should we name it --score-regions?

Hmm. My motivation was to use the same name as others.

but md-eval only supports --regions [all|nooverlap]

That shouldn't be a problem.

@thequilo
Copy link
Member Author

Hmm. My motivation was to use the same name as others.

--regions is not as self-explanatory, --score-regions gives a much better hint at what this "region" means. But since all names we found so far have problems, I'm pretty sure that anything we'll come up with will also have its flaws, so I'll stick with --regions.

@thequilo thequilo merged commit 38f5293 into main Feb 19, 2024
6 checks passed
@thequilo thequilo deleted the der-ignore-overlap branch February 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants