adds mtu and table to the config #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnhmcknight
requested changes
Dec 15, 2021
There was a problem hiding this comment.
This is a great addition. Once the table validation issue has been resolved, we can merge this. Thanks, @marneu!
jnhmcknight
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a inoffial description for "Table" and "MTU" on https://github.com/pirate/wireguard-docs#Table.
Normal Linux kernels support slots between 0 and 255 (http://linux-ip.net/html/routing-tables.html#idm140337857356016). The code within this request will limit "Table" to a value within ranges of 1 to 252,256-(2^31-1) (253-255 do not need an explicit "Table" definition). This is helpful in policy-based routing scenarios. Table can be set to auto (default) or off if the route shall not be created.
The max MTU value could be a constant, as Ethernet II networks have a standard frame size of 1518 bytes. After looking at the WG source there are some suggestions when issuing help(Peer)
If DNS is not set (in plain routed environment) the parameter shall not show up in the config.