Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api error object to exception #52

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add api error object to exception #52

wants to merge 2 commits into from

Conversation

JohannesHome
Copy link

  • Move ErrorObject and ErrorResponse to public model
  • Upgrade guava

@JohannesHome JohannesHome mentioned this pull request Mar 12, 2018
Open
JohannesHome
JohannesHome commented Mar 12, 2018
View reviewed changes
src/main/java/me/figo/FigoApi.java Outdated
}
}

private void logError(FigoException.ErrorResponse errorResponse, HttpURLConnection connection) {
private void logError(ErrorResponse errorResponse, HttpURLConnection connection) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to remove this log, but I'm not sure why it was added in the first place. My current workaround is that this logger is blocked by my configuration.

@JohannesHome
Add api error object to exception
c14bada 
* Move ErrorObject and ErrorResponse to public model
* Upgrade guava
@JohannesHome JohannesHome force-pushed the add-api-error-to-exception branch from c2ac450 to c14bada Compare March 12, 2018 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JohannesHome