Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update choices.js to ^11.0.2 #15585

Closed
wants to merge 1 commit into from
Closed

Conversation

informatJonas
Copy link

Description

Update choices.js to version ^11.0.2 (reason for this, in this version the grouping & single option in a select was fixed)

Adjustment in select.js => setChoices (An additional array element was mistakenly added during grouping, this is removed using choices.filter(...))

Visual changes

Before

image

After

image

Functional changes

  • Code style has been fixed by running the composer cs command. (I have not customized any Composer relevant files)
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

…n the grouping & single option in a select was fixed)

Adjustment in select.js => `setChoices` (An additional array element was mistakenly added during grouping, this is removed using `choices.filter(...)`)
@danharrin
Copy link
Member

Hi, this is a breaking change and has been upgraded for v4

@danharrin danharrin closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants