FIP process amendment to integrate spec update #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannisbot
requested review from
momack2,
whyrusleeping,
androowoo,
hugomrdias,
nicola and
daviddias
|
@hugomrdias the front matter syntax proposal here does not include the section-specific identifier we discussed previously. Please edit this PR once the per-section identifiers are ready. |
|
All sections in the spec now have a label that can be easily copy/pasted into a FIP frontmatter. |
|
@hugomrdias can you please give an example? For instance, for Section 2: Systems: https://spec.filecoin.io/#section-systems.systems, is the label
|
|
|
momack2
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
This looks good! We discussed in today's Core Devs meeting and generally approved this improvement to help keep the spec up to date: https://www.youtube.com/watch?v=58b8TY9LJaM
hugomrdias
suggested changes
Oct 27, 2020
Co-authored-by: Hugo Dias <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
Co-authored-by: Hugo Dias <[email protected]>
momack2
approved these changes
Nov 3, 2020
momack2
requested review from
hugomrdias and
daviddias
and removed request for
daviddias
daviddias
approved these changes
Nov 3, 2020
hugomrdias
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes slight changes to the FIP process to include integration with the Filecoin Specification. There has been discussion and agreement on the fact that if the Filecoin protocol is updated without the changes being directly reflected in the protocol's specification, then the spec will be outdated very soon.
The updates include slight procedural modifications, i.e., a PR to the spec repository is submitted before the FIP is marked as "Final", as well as a small syntax change on the front matter of the FIP Template to indicate which section(s) the FIP is touching upon. This change will allow pulling this information from the FIP repo directly into the Spec repo and will enable us to link to the FIP(s) applied to each section of the spec.
cc: @hugomrdias