Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-0049 (actor events): align with implementation. #581

Merged
merged 27 commits into from
Jan 9, 2023
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
2cec4c2
FIP-0049 (actor events): round of editing. Missing gas costs.
raulk Dec 27, 2022
cb88b82
fix nits.
raulk Dec 28, 2022
a3a4467
add a link to DAG-CBOR spec.
raulk Dec 28, 2022
06da825
add access control example.
raulk Dec 28, 2022
744fba1
elaborate on how events are committed on chain.
raulk Dec 28, 2022
2c4e9a6
address nits around flags.
raulk Dec 28, 2022
786201d
update the syscall.
raulk Dec 28, 2022
48e5e66
add test cases.
raulk Dec 28, 2022
742a46a
clarify 'external'.
raulk Dec 28, 2022
9fb21c5
cover fatal errors.
raulk Dec 28, 2022
f99cd75
link to indexing implementation in Lotus.
raulk Dec 28, 2022
a9ba904
paint the shed.
raulk Dec 30, 2022
d195975
another editing pass.
raulk Dec 30, 2022
b4dcba9
restrict values to DAG-CBOR byte strings; add Eth event.
raulk Dec 30, 2022
151d691
do not insert the event AMT into the blockstore.
raulk Dec 30, 2022
c6302d3
specify error situations in emit_event syscall.
raulk Dec 30, 2022
218c219
add Chain commitment section; align with implementation.
raulk Dec 30, 2022
1b370b6
restructure sections.
raulk Dec 30, 2022
0f5dee4
rearchitect gas costs.
raulk Dec 30, 2022
d06fdf1
various edits.
raulk Dec 30, 2022
c547b15
add security considerations.
raulk Dec 30, 2022
05f693f
minor edit for clarity.
raulk Jan 3, 2023
d002339
edits for clarity.
raulk Jan 9, 2023
53bf960
discuss choice of receipt data structure.
raulk Jan 9, 2023
2733c85
remove comment about events for built-in actors.
raulk Jan 9, 2023
9d88dcf
multiple edits.
raulk Jan 9, 2023
38e6aa4
update ToC.
raulk Jan 9, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
do not insert the event AMT into the blockstore.
raulk committed Dec 30, 2022
commit 151d6918b8e7fde751c1ab0b6d5db5d36719a3b6
8 changes: 4 additions & 4 deletions FIPS/fip-0049.md
Original file line number Diff line number Diff line change
@@ -273,10 +273,10 @@ FVM.
- Out of gas or fatal errors cause all events emitted by the call stack to be
discarded.

At the end of successful message execution, all retained `StampedEvent`s are
DAG-CBOR serialized and added to an AMT in their original emission order. The
AMT is flushed into the FVM's (buffered) blockstore, and the root CID of the AMT
is returned in the above `events` field.
At the end of successful message execution, the FVM serializes all retained
`StampedEvent`s to DAG-CBOR and adds them to an AMT with bitwidth 5, in their
natural position. The AMT's root CID is then returned to the client, along with
the events themselves.

Because the network agrees on the content of the receipts through the
`ParentMessageReceipts` on the `BlockHeader`, the events are implicitly