Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:add graphql server listen address config #1327

Merged
merged 3 commits into from
Apr 27, 2023
Merged

chore:add graphql server listen address config #1327

merged 3 commits into from
Apr 27, 2023

Conversation

rickiey
Copy link
Contributor

@rickiey rickiey commented Mar 24, 2023 •
edited
Loading

boost is deployed in the public network , I don't want to expose graphql port

jacobheun
jacobheun reviewed Apr 15, 2023
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Overall supportive of the change, but to avoid a change in default behavior we should keep the bind address consistent.

node/config/def.go Outdated Show resolved Hide resolved
node/config/types.go Outdated Show resolved Hide resolved
rickiey and others added 2 commits April 18, 2023 16:44
@nonsense nonsense merged commit 69d97c0 into filecoin-project:main Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobheun jacobheun jacobheun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rickiey @jacobheun @nonsense