yugabyte/service: parallel batch inserts for car indices #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonsense
force-pushed
the
nonsense/parallel-batch-inserts-for-indices
branch
from
317b9b1 to
f6fb85c
Compare
LexLuthr
approved these changes
Nov 1, 2023
ischasny
reviewed
Nov 1, 2023
| if batch == nil { | ||
| batch = s.session.NewBatch(gocql.UnloggedBatch).WithContext(ctx) | ||
| batch.Entries = make([]gocql.BatchEntry, 0, s.settings.InsertBatchSize) | ||
| threadBatch := len(recs) / 32 // split the slice into go-routine batches for ~32 workers |
There was a problem hiding this comment.
Shall we take an opportunity and extract batching / parallelisation logic into a separate function as it used twice
There was a problem hiding this comment.
I am merging this as is for now. We can shorten the code for next release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of the work @ischasny did with batch inserts for indices.
It basically splits the
recsslice (which can get from 0 up to 50M-100M entries), into 32 chunks that get processed in parallel.Considering that batch size is 10k, it makes sense to have concurrent go-routines working on inserting the index.