Depend on commit from main for boostd-data dependency #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When boost is built from source without cloning boostd-data extern folder the go module will pull the version in go.mod which used to point to a branch commit. The changes here changes to commit to point to a commit from main, head of `v2.1.0-rc3`. This is done by executing: `go get github.com/filecoin-project/boost/extern/boostd-data@1622d0ce2581bcaba6c1d1c6c46d2576576fa716` Run `go mod tidy` on root and nested modules. Fixes #1813
ischasny
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When boost is built from source without cloning boostd-data extern folder the go module will pull the version in go.mod which used to point to a branch commit.
The changes here changes to commit to point to a commit from main, head of
v2.1.0-rc3. This is done by executing:go get github.com/filecoin-project/boost/extern/boostd-data@1622d0ce2581bcaba6c1d1c6c46d2576576fa716Run
go mod tidyon root and nested modules.Fixes #1813