Don't publish deal sealing status update if no one is subscribed #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
force-pushed
the
feat/deal-seal-state-subs
branch
from
2de2754 to
754bf74
Compare
| } | ||
|
|
||
| func (s *updatesSubscription) Close() error { |
There was a problem hiding this comment.
Do we call this close when the deal is no longer in the first 10 deals on the UI ?
There was a problem hiding this comment.
Yes, it's called when the front end stops subscribing to events.
This can happen because
- the user closes the web page
- a new deal comes in that moves the last deal on the page to page 2 (ie no longer visible)
aarshkshah1992
approved these changes
Apr 4, 2022
dirkmc
added a commit
that referenced
this pull request
Apr 4, 2022
* feat: update UI when deal sealing state changes * Don't publish deal sealing status update if no one is subscribed (#401) * feat: dont check seal status change if no one is subscribed to events * refactor: rename to make subscription name clearer * feat: test that Proving event is fired when sealer reaches that state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.