Deal validation tests #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dirkmc
reviewed
Apr 5, 2022
itests/dummydeal_test.go
Outdated
Comment on lines
87
to
93
|
|
||
| // deal fails because signature is invalid | ||
| res, err = f.makeDummyDeal(dealUuid, carFilepath, rootCid, server.URL+"/"+filepath.Base(carFilepath), false, abi.NewTokenAmount(2000000), withInvalidSignature()) | ||
| require.NoError(t, err) | ||
| require.False(t, res.Accepted) | ||
| require.Contains(t, res.Reason, "error verifying signature") | ||
| log.Debugw("got response from MarketDummyDeal", "res", spew.Sdump(res)) |
There was a problem hiding this comment.
I think we don't really need the invalid signature and min ask tests at the dummy deal level if we're already testing these things in the provider unit test
There was a problem hiding this comment.
@dirkmc Dosen't hurt to have it for a sanity check as these are two important validations and these finish quickly as we don't wait for these deals to be sealed since they get rejected right off the bat.
There was a problem hiding this comment.
I think I'd rather keep all the validation testing in one place. Someone looking at this code later might think they should add validation testing code here. In general I favour having the minimal amount of tests to keep the code maintainable.
dirkmc
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216.