Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add transparent gzip support for booster-http response #932

Merged
merged 8 commits into from
Nov 8, 2022
Merged

feat: add transparent gzip support for booster-http response #932

merged 8 commits into from
Nov 8, 2022

Conversation

LexLuthr
Copy link
Collaborator

@LexLuthr LexLuthr commented Nov 4, 2022

resolves #830

@LexLuthr LexLuthr requested a review from dirkmc November 4, 2022 11:45
dirkmc
dirkmc reviewed Nov 4, 2022
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good so far..

cmd/booster-http/http_test.go Outdated Show resolved Hide resolved
cmd/booster-http/server.go Outdated Show resolved Hide resolved
@LexLuthr LexLuthr requested a review from dirkmc November 7, 2022 09:19
@dirkmc
Copy link
Contributor

dirkmc commented Nov 7, 2022

Looks great 👍

I'd suggest one more change: instead of generating a random file, create a fixtures directory for the test with

  • a raw file
  • the raw file gzipped

Then in the test

  • return a reader over the raw file from the mock
  • read the bytes from response.Body
  • confirm that the bytes are the same as the gzipped file

@LexLuthr LexLuthr merged commit d2c82f3 into main Nov 8, 2022
@LexLuthr LexLuthr deleted the feat/http-gzip branch November 8, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkmc dirkmc dirkmc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

booster-http: add transparent gzip support
2 participants
@LexLuthr @dirkmc