Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move 2 fixes over to FVM #55

Closed
2 tasks done
laudiacay opened this issue Jan 10, 2022 · 6 comments
Closed
2 tasks done

move 2 fixes over to FVM #55

laudiacay opened this issue Jan 10, 2022 · 6 comments
Labels
P1
Milestone
Network v16

Comments

@laudiacay
Copy link

laudiacay commented Jan 10, 2022 •
edited by Stebalien
Loading

@laudiacay laudiacay self-assigned this Jan 10, 2022
@laudiacay
Copy link
Author

part 1 : https://github.com/filecoin-project/fvm/pull/237

@jennijuju jennijuju transferred this issue from filecoin-project/ref-fvm Mar 7, 2022
@jennijuju jennijuju added this to the Network v16 milestone Mar 7, 2022
@jennijuju jennijuju assigned arajasek and unassigned laudiacay Mar 7, 2022
@jennijuju
Copy link
Member

immediate task is to confirm these two work has landed cc @arajasek

@raulk
Copy link
Member

raulk commented Mar 11, 2022

Fix 1 is present in builtin-actors:

builtin-actors/actors/market/src/lib.rs

Line 413 in dd314c6

continue;

@raulk
Copy link
Member

raulk commented Mar 11, 2022

Fix 2 has not been ported. @Stebalien is checking it.

@raulk raulk mentioned this issue Mar 11, 2022
Merged
@Stebalien
Copy link
Member

The first part of the fix has been merged here, the second part is in an open PR: #96

@arajasek arajasek removed their assignment Mar 12, 2022
@raulk
Copy link
Member

raulk commented Mar 14, 2022

This is all done now with the last two pieces landing:

@raulk raulk closed this as completed Mar 14, 2022
Repository owner moved this from Todo to Done in Network v16 (Skyr) - FVM M1 Upgrade Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1
Projects
No open projects
Network v16 (Skyr) - FVM M1 Upgrade
Archived in project
Milestone
Network v16
Development

No branches or pull requests
5 participants
@Stebalien @raulk @arajasek @laudiacay @jennijuju