fixing by adding max index computation in bitfield validation #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laudiacay
requested review from
connormullett,
ec2,
elmattic and
noot
as code owners
elmattic
requested changes
Jan 5, 2022
There was a problem hiding this comment.
You could also add the offensive payload from Alex in a test:
#[test]
fn iter_last() {
// Create RLE with 2**64-2 set bits:
let rle: Vec<u8> = vec![0xE4, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x2F, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0xFF, 0x7F];
let (_bf, max) = BitField::from_bytes_with_max(&rle).unwrap();
assert_eq!(max, 18446744073709551614);
}
adacd00 to
cc3991f
Compare
|
idk how to close ur requested changes but... addressed! |
elmattic
reviewed
Jan 11, 2022
|
|
||
| #[allow(clippy::absurd_extreme_comparisons)] | ||
| if last_sector_number > MAX_SECTOR_NUMBER { | ||
| if (last_sector_number as u64) > MAX_SECTOR_NUMBER { |
There was a problem hiding this comment.
You can have kept the type alias SectorNumber here. But otherwise lgtm.
elmattic
approved these changes
Jan 11, 2022
laudiacay
force-pushed
the
fix-b4-bitfield
branch
2 times, most recently
from
80d8cc3 to
0a64a7f
Compare
|
@laudiacay could you merge main into this when you get a chance? the clippy issues were fixed on main |
laudiacay
force-pushed
the
fix-b4-bitfield
branch
from
0a64a7f to
873796b
Compare
2 tasks
Stebalien
added a commit
to filecoin-project/builtin-actors
that referenced
this pull request
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
no relevant issue
Other information and links
See audit slack channel. ready to review, but please please look over this closely! bitfields are easy places to mess up...