EVM: Allow Null Addresses to convert into f4 Addresses #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
approved these changes
Jan 6, 2023
| @@ -158,4 +162,27 @@ mod tests { | |||
| vec![0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01].as_slice() // ID address (u64 big endian) (8 bytes) | |||
| ] => None, | |||
| } | |||
|
|
|||
| #[test] | |||
| #[allow(unused)] | |||
There was a problem hiding this comment.
Err value of the TryFrom trait for EthAddress to Address: "output::StatusCode must be used"
There was a problem hiding this comment.
Hm. It's better to write that as let _ = .... Otherwise, you can miss other error cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly reject Null address being created by the EAM.
Side note: we should be deploying an Eth account at null address during network startup.