market: Real-world fixes #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LexLuthr
approved these changes
Nov 6, 2024
magik6k
force-pushed
the
fix/market-adventures
branch
7 times, most recently
from
de2dde8 to
486cd9a
Compare
|
The DenyUnknownClients appears to be flipped, at least in the webui |
magik6k
force-pushed
the
fix/market-adventures
branch
2 times, most recently
from
bc622a3 to
ab418de
Compare
magik6k
force-pushed
the
fix/market-adventures
branch
from
029ceb4 to
5ed280a
Compare
magik6k
force-pushed
the
fix/market-adventures
branch
from
c05a071 to
95cad2d
Compare
LexLuthr
approved these changes
Dec 6, 2024
| @@ -160,20 +153,35 @@ func StartHTTPServer(ctx context.Context, d *deps.Deps) error { | |||
| Addr: cfg.ListenAddress, | |||
| Handler: libp2pConnMiddleware(loggingMiddleware(compressionMw(chiRouter))), // Attach middlewares | |||
| ReadTimeout: cfg.ReadTimeout, | |||
| WriteTimeout: cfg.WriteTimeout, | |||
| WriteTimeout: time.Hour * 2, | |||
There was a problem hiding this comment.
Can we use default here instead of a hardcoded value?
There was a problem hiding this comment.
So WriteTimeout generally isn't useful for mitigating much, unless you're trying to mitigate successful retrievals.
Later we could bring a much more advanced write rate enforcer from ribs so that /piece uploads have reasonable bounds, but for now setting a low write timeout guarantees that retrievals will fail
Ref https://github.com/FilOzone/ribs/blob/main/ributil/minratewriter.go
magik6k
force-pushed
the
fix/market-adventures
branch
from
c7bcaa1 to
8b8bf64
Compare
LexLuthr
approved these changes
Dec 10, 2024
LexLuthr
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet, keeping this around until it mostly works