Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM build to CI #274

Closed
vmx opened this issue May 2, 2022 · 7 comments · Fixed by #340
Closed

Add ARM build to CI #274

vmx opened this issue May 2, 2022 · 7 comments · Fixed by #340
Assignees
Labels
good first issue Good for newcomers

Comments

@vmx
Copy link
Contributor

vmx commented May 2, 2022

Currently we don't build the FFI on CI for ARM, but we should, to make sure we don't break it.

@airenas
Copy link

airenas commented Sep 23, 2022

When building dockerfiles for lotus and boost on native arm platform (like Mac M1) we are forced to build filecoin-ffi from source as there are no prebuild Linux arm binaries. Having it would speed up the docker builds.

Also it, perhaps, would require some change in install-filcrypto file: the line local __release_name="${__repo_name}-$(uname)-${release_flag_name}". Now it according uname always downloads Linux binaries that are only x86 compatible.

@LaurenSpiegel
Copy link

@vmx , any anticipated timing for this? if you need help in getting done, @airenas , do you have some time to help?

@airenas
Copy link

airenas commented Nov 23, 2022

I see Draft #287, perhaps, you just need to finalize it.

@vmx
Copy link
Contributor Author

vmx commented Nov 23, 2022

@LaurenSpiegel Currently don't have any plans for implementing this. If there's a need for fixing this issue, perhaps @shawnrader may also be able to help.

@shawnrader
Copy link
Contributor

I can get to this next week.

@shawnrader shawnrader linked a pull request Nov 29, 2022 that will close this issue
@shawnrader
Copy link
Contributor

I linked a pull request to add aarch64 Linux build, test, and publish to CI. Apple M1/M2 support will need to be done as a different task and right now CircleCI only supports cross compilation from Intel Mac.

@shawnrader
Copy link
Contributor

This issue for tracking mac M1 builds: #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants