chore: build filecoin-ffi on arm based OS #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmx
reviewed
May 11, 2022
| @@ -0,0 +1,27 @@ | |||
| # filecoin-ffi build workaround | |||
|
|
|||
| As of this writing, .circleci does not support arm based images and as a workaround we need to try and build the filecoin-ffi in a containerized environment. The workaround is to create a docker image using an ARM64 based operating system and build the binaries in the image. We can then pull (`cp`) the binaries to the host. | |||
There was a problem hiding this comment.
I'm not sure what "arm based images" are, but CircleCI has ARM64 support, which is e.g. be used by rust-fil-proofs: https://github.com/filecoin-project/rust-fil-proofs/blob/6260c2a5409bda6c2514e8c355d52623939f4bc7/.circleci/config.yml#L19-L22
There was a problem hiding this comment.
Ok. Thank you for this. I'll experiment with this image then.
I saw this note on circle ci.
Closed
|
ARM build were introduced, so I don't think this PR is needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to build filecoin-ffi on arm-based OS. This utilizes ubuntu but I also listed a few potential images that can be used.