run the Rust tests before running the Go tests #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laser
force-pushed
the
bugs/run-rust-tests-circleci
branch
from
33c2419 to
2a77dc5
Compare
laser
changed the title
cryptonemo
added a commit
that referenced
this pull request
Jun 24, 2020
fix: borrow some fixes from PR #112
Transferring ownership to Rust (test) meant that string-memory was freed twice: once when the Rust string goes out of scope, and once when fil_destroy_string_response is called. That was bad.
laser
force-pushed
the
bugs/run-rust-tests-circleci
branch
from
8610739 to
cb78519
Compare
laser
force-pushed
the
bugs/run-rust-tests-circleci
branch
from
3bd4979 to
ca74dc1
Compare
cryptonemo
approved these changes
Jun 25, 2020
gracenoah
pushed a commit
to gracenoah/filecoin-ffi
that referenced
this pull request
Dec 20, 2020
fix: borrow some fixes from PR filecoin-project#112
gracenoah
pushed a commit
to gracenoah/filecoin-ffi
that referenced
this pull request
Dec 20, 2020
* run the Rust tests before running the Go tests * remove problematic unused (and broken) cid accessors * use CStr instead of CString to prevent double-free in test Transferring ownership to Rust (test) meant that string-memory was freed twice: once when the Rust string goes out of scope, and once when fil_destroy_string_response is called. That was bad. * restore temporarily disabled test functions * remove errand debug * don't need to ignore log test * set parameter cache explicitly * bump cache key * ignore leaky log-to-fd test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this PR needs to be merged and available through rust-filecoin-proofs-api before this PR can be merged.doneWhy does this PR exist?
CircleCI should run the Rust tests in addition to the Go tests.
What's in this PR?
This PR modifies the CircleCI config to run the Rust tests. It also fixes a bug in the Rust tests which caused a double free-failure.