Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: plumb codec through lotus trace #379

Merged
merged 2 commits into from
Mar 1, 2023
Merged

Conversation

Stebalien
Copy link
Member

This replaces the trace types with FVM specific ones. It:

  • Adds codecs to params/return values.
  • Removes unset fields like nonce, gas, etc.

@Stebalien
Copy link
Member Author

This will require some extensive changes in lotus, so I'll tackle those first.

This replaces the trace types with FVM specific ones. It:

- Adds codecs to params/return values.
- Removes unset fields like nonce, gas, etc.
- Removes the error string field (error information is still included in
  the top-level error message.
- Adds timing information to gas charges.
@Stebalien Stebalien force-pushed the feat/plumb-lotus-trace branch from d3e0b70 to 8e65427 Compare March 1, 2023 01:06
Copy link
Contributor

@arajasek arajasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Can we drop this TODO about the backtrace? I think we're sending that info up to Lotus?

// TODO: Do something with the backtrace.

@Stebalien Stebalien merged commit b17eb3b into master Mar 1, 2023
@Stebalien Stebalien deleted the feat/plumb-lotus-trace branch March 1, 2023 20:19
Stebalien added a commit that referenced this pull request Apr 19, 2023
ZenGround0 added a commit that referenced this pull request Apr 19, 2023
Revert "feat: plumb codec through lotus trace (#379)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants