Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use the scaled power for winning tickets #375

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

Stebalien
Copy link
Member

This brings us in-line with the FIP.

This brings us in-line with the FIP.
@Stebalien Stebalien requested a review from anorth June 25, 2024 22:52
@Stebalien
Copy link
Member Author

Note: we can't throw away the unscaled powers because we need them for:

  1. Re-calculating power scaling (unfortunately, due to how our tests are written, we need the ability to add entries to the power table).
  2. Commit to the power table, etc.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (2ddf410) to head (5516b94).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          15       15           
  Lines        1778     1778           
=======================================
  Hits         1477     1477           
  Misses        175      175           
  Partials      126      126           
Files Coverage Δ
gpbft/gpbft.go 85.22% <100.00%> (ø)
gpbft/message_builder.go 75.38% <100.00%> (ø)
gpbft/powertable.go 86.66% <100.00%> (ø)

@Stebalien Stebalien added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit f2319a9 Jun 25, 2024
7 checks passed
@Stebalien Stebalien deleted the steb/use-scaled-power-for-ticket branch June 25, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants