Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend manifest with chain exchange configuration #810

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

masih
Copy link
Member

@masih masih commented Dec 20, 2024

Add chain exchange configuration to the manifest along with validation.

Part of #792

@masih masih requested a review from Kubuxu December 20, 2024 13:44
@masih masih force-pushed the masih/chainexchange-mfst branch from 42ea078 to ab2aca1 Compare December 20, 2024 13:46
@masih masih changed the base branch from main to masih/pubsub-chainexchange-listener December 20, 2024 13:51
@masih masih removed the request for review from Kubuxu December 20, 2024 13:51
@masih masih force-pushed the masih/chainexchange-mfst branch from ab2aca1 to 3e33616 Compare December 20, 2024 13:56
@masih masih marked this pull request as draft December 20, 2024 14:03
@masih masih force-pushed the masih/chainexchange-mfst branch from 3e33616 to 0c8b3e4 Compare December 20, 2024 14:04
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.

Project coverage is 68.61%. Comparing base (fbd674a) to head (9a2a898).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
manifest/manifest.go 26.92% 16 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   68.82%   68.61%   -0.21%     
==========================================
  Files          81       81              
  Lines        8281     8307      +26     
==========================================
+ Hits         5699     5700       +1     
- Misses       2096     2117      +21     
- Partials      486      490       +4     
Files with missing lines Coverage Δ
manifest/manifest.go 49.47% <26.92%> (-3.58%) ⬇️

... and 7 files with indirect coverage changes

@masih masih force-pushed the masih/pubsub-chainexchange-listener branch 3 times, most recently from b200822 to 7c4840e Compare December 20, 2024 16:43
Base automatically changed from masih/pubsub-chainexchange-listener to main January 6, 2025 16:11
Add chain exchange configuration to the manifest along with validation.

Part of #792
@masih masih force-pushed the masih/chainexchange-mfst branch from 0c8b3e4 to 9a2a898 Compare January 6, 2025 16:37
@masih masih marked this pull request as ready for review January 6, 2025 16:38
@masih masih requested a review from Kubuxu January 6, 2025 16:38
@BigLep BigLep added this to the M2: Mainnet Passive Testing milestone Jan 6, 2025
@masih masih added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit 3507ce2 Jan 7, 2025
13 of 14 checks passed
@masih masih deleted the masih/chainexchange-mfst branch January 7, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants