Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the validity of ECChain first in chain exchange #837

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

masih
Copy link
Member

@masih masih commented Jan 21, 2025

Add ECChain validation to chain exchange pubsub validation function to reject invalid chains as early as possible.

Change the ordering of validation rules such that cheaper checks are done first before checking current progress.

Add `ECChain` validation to chain exchange pubsub validation function to
reject invalid chains as early as possible.

Change the ordering of validation rules such that cheaper checks are
done first before checking current progress.
@masih masih self-assigned this Jan 21, 2025
@masih masih requested a review from Kubuxu January 21, 2025 17:02
@masih masih enabled auto-merge January 21, 2025 17:02
@masih masih added this to the M2: Mainnet Passive Testing milestone Jan 21, 2025
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.32%. Comparing base (9c11ba3) to head (6ca8dc2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
chainexchange/pubsub.go 0.00% 7 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   67.39%   67.32%   -0.07%     
==========================================
  Files          84       84              
  Lines        8915     8921       +6     
==========================================
- Hits         6008     6006       -2     
- Misses       2380     2388       +8     
  Partials      527      527              
Files with missing lines Coverage Δ
chainexchange/pubsub.go 74.78% <0.00%> (-3.29%) ⬇️

... and 5 files with indirect coverage changes

@masih masih requested a review from rvagg January 22, 2025 09:24
@masih masih added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit a61a42e Jan 22, 2025
13 of 14 checks passed
@masih masih deleted the masih/chainex-validation branch January 22, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants