Add new methods and types for FEVM #143
Conversation
| "golang.org/x/xerrors" | ||
| ) | ||
|
|
||
| type CborBytes []byte |
There was a problem hiding this comment.
We should consider putting this into cbor-gen (and using cborgen's ReadByteArray/WriteByteArray.
There was a problem hiding this comment.
...future...improvement...
There was a problem hiding this comment.
| return err | ||
| } | ||
|
|
||
| if extra > cbg.ByteArrayMaxLen { |
There was a problem hiding this comment.
This is probably too small (e.g., it won't fit an entire smart contract).
There was a problem hiding this comment.
Hmm, if so we have a more serious problem -- this limit applies to pretty much every type in Filecoin (as implemented by Golang clients), including the Message itself. That means Lotus won't consider such messages valid.
(what happens here in GST is less important since it's only used for UX)
There was a problem hiding this comment.
Steven is confused. Steven will go back to the caverns of rust.
(the max here is ~2MiB and isn't a problem)
New types, methods, and actors that have been added to the built-in actors.