Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fault/recover event still happen after a termination event #1031

Closed
xuyaoshell opened this issue Aug 11, 2022 · 1 comment · Fixed by #1032
Closed

Fault/recover event still happen after a termination event #1031

xuyaoshell opened this issue Aug 11, 2022 · 1 comment · Fixed by #1032
Assignees
@frrist
Labels
kind/bug Kind: Bug
Milestone
Lily v0.12.0

Comments

@xuyaoshell
Copy link

Describe the bug:

image
Some sectors seem to fault/recover even after a termination event.

Steps to Reproduce:

Lily Version: v0.11.0
@xuyaoshell xuyaoshell added the kind/bug Kind: Bug label Aug 11, 2022
@frrist frrist self-assigned this Aug 11, 2022
@frrist frrist mentioned this issue Aug 13, 2022
Merged
@frrist
Copy link
Member

frrist commented Aug 13, 2022

Thanks for filing @xuyaoshell. A fix has been created int #1032

@frrist frrist added this to the Lily v0.12.0 milestone Aug 16, 2022
frrist added a commit that referenced this issue Aug 23, 2022
@frrist
fix: extract miner sector state changes (#1032)
45f15be 
* fix: extract miner sector state changes

- the previous implementation diffed previous and current partitions, this was incorrect since miners
may compact their partitions resulting in sectors moving to different partitions. Instead we
collect all sectors from all miner partitions and diff the sets directly.
- fixes #1031
@frrist frrist pinned this issue Aug 24, 2022
@frrist frrist mentioned this issue Aug 24, 2022
Open
@frrist frrist unpinned this issue Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frrist frrist

Labels
kind/bug Kind: Bug
Projects
None yet
Milestone
Lily v0.12.0
Development

Successfully merging a pull request may close this issue.

fix: extract miner sector state changes filecoin-project/lily
2 participants
@frrist @xuyaoshell