Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Efficent state tree diffing is broken in nv18-rc1 #1144

Closed
frrist opened this issue Feb 28, 2023 · 0 comments
Closed

Efficent state tree diffing is broken in nv18-rc1 #1144

frrist opened this issue Feb 28, 2023 · 0 comments
Assignees
@frrist
Labels
kind/bug Kind: Bug P0 P0: Critical Blocker

Comments

@frrist
Copy link
Member

frrist commented Feb 28, 2023 •
edited
Loading

Describe the bug:

The default actor type in lotus has changed, it now has a new field: https://github.com/filecoin-project/lotus/blob/master/chain/types/actor.go#L33 this causes unmarshalling actors here to fail: https://github.com/filecoin-project/lily/blob/master/chain/datasource/datasource.go#L393-L416 since their encoded bytes are different depending on network version.

Steps to Reproduce:

Run a walk or watch job

Lily Version: frrist/nv18-rc1
@frrist frrist added kind/bug Kind: Bug P0 P0: Critical Blocker labels Feb 28, 2023
@frrist frrist self-assigned this Feb 28, 2023
frrist added a commit that referenced this issue Feb 28, 2023
@frrist
fix: correctly diff new actor version
4e7c3fc 
- closes #1144
@frrist frrist mentioned this issue Feb 28, 2023
Merged
frrist added a commit that referenced this issue Mar 2, 2023
@frrist
fix: correctly diff new actor version (#1145)
f014011 
* fix: correctly diff new actor version

- closes #1144

* chore: remove unused metrics

* metric: track GettActorStateChanges duration
Terryhung pushed a commit that referenced this issue Mar 3, 2023
@frrist
fix: correctly diff new actor version (#1145)
5f82b10 
* fix: correctly diff new actor version

- closes #1144

* chore: remove unused metrics

* metric: track GettActorStateChanges duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frrist frrist

Labels
kind/bug Kind: Bug P0 P0: Critical Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@frrist