Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsealing enhancements #10316

Closed
8 of 9 tasks
Tracked by #10340
rjan90 opened this issue Feb 20, 2023 · 1 comment
Closed
8 of 9 tasks
Tracked by #10340

Unsealing enhancements #10316

rjan90 opened this issue Feb 20, 2023 · 1 comment

Comments

@rjan90
Copy link
Contributor

rjan90 commented Feb 20, 2023

Context: This issue originally started out as Investigaton of storing tree_r_last in Lotus-Miner to see how we could make unsealing better, which lead us to a longer path of unsealing enhancements after discussions with the proofs-team. This issue ticket has therefore been repurposed reflect that epic.

User story:
As a storage provider (SP) who stores sealed sectors, I need an efficient and reliable unsealing process which does not require manual work to attach workers to where the sealed sector is located, allowing me to focus on handling large volume of sealed sectors being unsealed for clients.

Acceptence criteria:

  • Unsealing of every sector type (Deals, SnapDeal) functions without bugs.
  • The unsealing process should not require manual intervention for unsealing to work on unsealing-workers; such as attaching the location where the sealed sector is stored to a worker.

Techincal scope

Point estimation:

@rjan90 rjan90 moved this to ⭐️ In Scope in Lotus-Miner-V2 Mar 2, 2023
@rjan90 rjan90 added this to the Lotus-Miner Backlog Sprint milestone Mar 2, 2023
@rjan90 rjan90 moved this to ⭐️ In Scope in Lotus-Miner-V2 Mar 24, 2023
@rjan90 rjan90 modified the milestones: LM-v1.23.1, LM-v1.23.2 May 12, 2023
@rjan90 rjan90 changed the title Investigate concept of storing tree_r_last in Lotus [Epic] Unsealing enhancements Jun 13, 2023
@rjan90 rjan90 removed this from the LM-v1.23.2 milestone Jun 15, 2023
@rjan90 rjan90 changed the title [Epic] Unsealing enhancements Unsealing enhancements Jun 15, 2023
@rjan90 rjan90 added this to the Unsealing enhancements milestone Jun 15, 2023
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 5, 2023

Closing this issue now that #11011 has been merged, and is on its way to users with the Lotus v1.23.4 release train.

The linked PR introduces significant improvements and bugfixes with regards to unsealing, and ensures that unsealing operates as anticipated. Consequently, the unsealing of deal sectors, Snap-sectors without sector keys, and Snap-sectors with sector keys now all function seamlessly.

Additional improvements/bugfixes with this PR includes:

  • Enabling unsealing on workers with only sealing paths. 🎉
  • Transferring unsealed files to long-term storage upon successful unsealing. ➡️
  • Ensuring no residual files in sealing paths post a successful unsealing operation. 🧹

One area to explore further is if want to spend additional time splitting the "PC1-step" (TreeD building and SDR) in the unsealing pipeline. See the More efficient deal data pipeline section in https://pl-strflt.notion.site/Improved-APIs-for-Lotus-9bd4fa443e254701a081f51ad301fddf.

@rjan90 rjan90 closed this as completed Sep 5, 2023
@github-project-automation github-project-automation bot moved this from ⭐️ In Scope to 👀 In Review in Lotus-Miner-V2 Sep 5, 2023
@rjan90 rjan90 moved this from 👀 In Review to ✅ Done in Lotus-Miner-V2 Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

1 participant