Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create the sealed file in precommit1 #1665

Closed
Tracked by #10316
magik6k opened this issue Feb 28, 2023 · 1 comment
Closed
Tracked by #10316

Don't create the sealed file in precommit1 #1665

magik6k opened this issue Feb 28, 2023 · 1 comment

Comments

@magik6k
Copy link

magik6k commented Feb 28, 2023

Today precommit1 just copies unsealed bytes to the 'sealed' file, and does nothing else with them ->

// Copy unsealed data to output location, where it will be sealed in place.
fs::copy(&in_path, &out_path).with_context(|| {
format!(
"could not copy in_path={:?} to out_path={:?}",
in_path.as_ref().display(),
out_path.as_ref().display()
)
})?;

This leads to confusion, and redundant work on lotus side as it needs to manage that file between PC1/2.

Ideally Precommit1 would either not create the sealed file at all - that would happen in early PC2, or the sealed file would actually contain the correct, sealed data (in which case PC2 could possibly not require unsealed data access?)

@vmx
Copy link
Contributor

vmx commented May 26, 2023

This issue is about bundling to many things in the single precommit1 call. Those things have been split and are available through the FFI PR at filecoin-project/filecoin-ffi#402.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants