-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reject Eth subscriptions & filters through the gateway over HTTP #11153
Labels
Comments
11 tasks
This was referenced Jul 26, 2024
rvagg
added a commit
that referenced
this issue
Jul 31, 2024
rvagg
added a commit
that referenced
this issue
Aug 1, 2024
rvagg
added a commit
that referenced
this issue
Aug 1, 2024
rvagg
added a commit
that referenced
this issue
Aug 5, 2024
rvagg
added a commit
that referenced
this issue
Aug 5, 2024
rvagg
added a commit
that referenced
this issue
Aug 8, 2024
rvagg
added a commit
that referenced
this issue
Aug 9, 2024
rjan90
pushed a commit
to hanabi1224/lotus
that referenced
this issue
Aug 12, 2024
rjan90
pushed a commit
that referenced
this issue
Aug 12, 2024
ribasushi
pushed a commit
to ribasushi/ci-abusing-lotus-fork
that referenced
this issue
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, the lotus gateway forgets all eth subscriptions and event filters between HTTP calls. These APIs only work over the websocket transport.
This happens because:
See
lotus/gateway/handler.go
Lines 89 to 96 in 9310cd6
Proposal: In the relevant Eth API methods (all those either taking or returning an
EthFilterID
and/or anEthSubscriptionID
), check if the request is being made via a websocket and, if not, reject it with an error explaining that the API is only supported over the websocket transport.Motivation: Users aren't confused because this just silently refuses to work. Instead, users will get a nice error message telling them to use a websocket if they need to use this API.
The text was updated successfully, but these errors were encountered: