Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail early if the deals are expired during PRU handlings #7869

Closed
jennijuju opened this issue Jan 3, 2022 · 2 comments · Fixed by #7871
Closed

Fail early if the deals are expired during PRU handlings #7869

jennijuju opened this issue Jan 3, 2022 · 2 comments · Fixed by #7871
Labels
P1 P1: Must be resolved SnapDeals
Milestone
v1.14.0

Comments

@jennijuju
Copy link
Member

like in handleReplicaUpdate, we should add more deal error/expiration handling in handleProveReplicaUpdate1 and handleProveReplicaUpdate2
@jennijuju jennijuju added this to the v1.14.0 milestone Jan 3, 2022
@jennijuju jennijuju added the P1 P1: Must be resolved label Jan 3, 2022
@jennijuju
Copy link
Member Author

probably in handleSubmitReplicaUpdate too

@jennijuju jennijuju mentioned this issue Jan 4, 2022
Merged
5 tasks
@jennijuju jennijuju linked a pull request Jan 4, 2022 that will close this issue
fix: #7869 sealing: Add more deal expiration checks during PRU pipeline #7871
Merged
5 tasks
@BlocksOnAChain
Copy link
Contributor

@jennijuju @arajasek - this can probably include the following "to do" you mentioned :

lotus/extern/storage-sealing/input.go

Line 118 in f7884c4

// todo check deal age, start sealing if any deal has less than X (configurable) to start deadline

@jennijuju jennijuju modified the milestones: v1.14.0, SnapDeals Jan 5, 2022
arajasek added a commit that referenced this issue Jan 12, 2022
@arajasek
Merge pull request #7871 from filecoin-project/jen/7869
f955084 
fix: #7869 sealing: Add more deal expiration checks during PRU pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 P1: Must be resolved SnapDeals
Projects
None yet
Milestone
v1.14.0
Development

Successfully merging a pull request may close this issue.

fix: #7869 sealing: Add more deal expiration checks during PRU pipeline filecoin-project/lotus
2 participants
@jennijuju @BlocksOnAChain