Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Non-eth transactions can be queried by hash #10026

Closed

Conversation

geoff-vball
Copy link
Contributor

@geoff-vball geoff-vball commented Jan 16, 2023

Related Issues

Cherry-picks #9965 which is still review, but was needed to test all functionality.

Fixes regressions in https://github.com/filecoin-project/lotus/pull/10017/files

Proposed Changes

Fixes regressions where non-eth transactions could not be queried by hash through the API.

Additional Info

Looking at the PR by commit will be much easier.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@geoff-vball geoff-vball force-pushed the gstuart/improve-tx-to-msg-tx-hash-db branch 4 times, most recently from c7edad9 to ca5de4a Compare January 16, 2023 11:44
@geoff-vball geoff-vball changed the base branch from release/v1.20.0 to asr/improve-tx-to-msg January 16, 2023 11:46
@geoff-vball geoff-vball force-pushed the gstuart/improve-tx-to-msg-tx-hash-db branch 11 times, most recently from e6fbd59 to 9ff6045 Compare January 16, 2023 11:59
@geoff-vball geoff-vball force-pushed the gstuart/improve-tx-to-msg-tx-hash-db branch 2 times, most recently from c92fcc0 to ab5c287 Compare January 16, 2023 12:35
@geoff-vball geoff-vball force-pushed the gstuart/improve-tx-to-msg-tx-hash-db branch from ab5c287 to d7ded62 Compare January 16, 2023 12:43
@geoff-vball geoff-vball marked this pull request as ready for review January 16, 2023 13:13
@geoff-vball geoff-vball requested a review from a team as a code owner January 16, 2023 13:13
@geoff-vball geoff-vball changed the title Draft: wrangle tx conversion fix: Non-eth transactions can be queried by hash Jan 16, 2023
@geoff-vball
Copy link
Contributor Author

Closed in favor of #10095

@jennijuju jennijuju added this to the Network v18 milestone Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants