feat: API for EthGetMessageCidByTransactionHash #10055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoff-vball
force-pushed
the
gstuart/tx-hash-to-msg-cid
branch
3 times, most recently
from
f87d4d4 to
b919bb5
Compare
geoff-vball
force-pushed
the
gstuart/tx-hash-to-msg-cid
branch
from
b919bb5 to
5133b9d
Compare
raulk
reviewed
Jan 18, 2023
| @@ -299,8 +300,53 @@ func (a *EthModule) EthGetTransactionByHash(ctx context.Context, txHash *ethtype | |||
| return nil, nil | |||
| } | |||
|
|
|||
| func (a *EthModule) EthGetMessageCidByTransactionHash(ctx context.Context, txHash *ethtypes.EthHash) (*cid.Cid, error) { | |||
There was a problem hiding this comment.
Looks like we're missing a positive test for this?
raulk
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Implements an API endpoint for getting a message CID from an Ethereum Transaction Hash.
Fixes a bug in
EthGetTransactionHashByCidwhere it would return a transaction hash even if the message didn't exist.EthGetTransactionHashByCidwill now return a transaction hash iff the message for the given cid is found in the node's store.Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps