Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eth JSON-RPC: implement web3_clientVersion #10113

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Eth JSON-RPC: implement web3_clientVersion #10113

merged 2 commits into from
Jan 25, 2023

Conversation

ychiaoli18
Copy link
Contributor

@ychiaoli18 ychiaoli18 commented Jan 25, 2023 •
edited
Loading

Related Issues

Proposed Changes

  • Implement the web3_clientVersion for the Eth JSON-RPC and include the Lotus's version in the response.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@ychiaoli18 ychiaoli18 requested a review from a team as a code owner January 25, 2023 03:57
@ychiaoli18 ychiaoli18 changed the base branch from master to release/v1.20.0 January 25, 2023 03:57
@ychiaoli18 ychiaoli18 requested a review from raulk January 25, 2023 04:34
@maciejwitowski maciejwitowski self-requested a review January 25, 2023 15:51
maciejwitowski
maciejwitowski approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@maciejwitowski maciejwitowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure about failing tests so please take a look. Thanks!

@geoff-vball
Copy link
Contributor

I reran the flaky tests. Everything looks good :)

@ychiaoli18 ychiaoli18 enabled auto-merge (squash) January 25, 2023 16:59
@geoff-vball geoff-vball disabled auto-merge January 25, 2023 20:11
@geoff-vball geoff-vball merged commit c6829a9 into release/v1.20.0 Jan 25, 2023
@geoff-vball geoff-vball deleted the feat/web3_clientVersion branch January 25, 2023 20:11
@Fatman13 Fatman13 mentioned this pull request Jan 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejwitowski maciejwitowski maciejwitowski approved these changes

@geoff-vball geoff-vball geoff-vball approved these changes

@raulk raulk Awaiting requested review from raulk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ychiaoli18 @geoff-vball @maciejwitowski