Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:must close when sqlite return sql.Rows #10143

Closed

Conversation

imxyb
Copy link
Contributor

@imxyb imxyb commented Jan 30, 2023

Related Issues

After the sqlite query returns sql.Rows, which should need to be closed, otherwise it will result in too many open files

Proposed Changes

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@imxyb imxyb requested a review from a team as a code owner January 30, 2023 09:57
@imxyb imxyb changed the title fix:rows must close when sqlite return sql.Rows fix:must close when sqlite return sql.Rows Jan 30, 2023
@geoff-vball geoff-vball mentioned this pull request Jan 30, 2023
7 tasks
@geoff-vball
Copy link
Contributor

Thank you so much for finding/fixing this bug!!

I've opted to refactor the method to call QueryRows() instead of Query() which cleans up the code nicely. The PR is here #10144

@imxyb imxyb closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants