-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperspace nv20 staging branch #10240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This checks Eth API consistency by walking the chain backwards from HEAD and verifying that all data returned from eth_getBlockByNumber is consistent with eth_getBlockByHash.
We no longer use the nonce here.
1. We do allow deploying with empty initcode. 2. Make sure that the encoded "code" is non-empty, if specified. Basically, this makes everything consistent (and it's how I specified it in the FIP).
Otherwise we may, e.g., try to estimate gas on a message to an f4 address before the nv18 migration. I'm _not_ checking the "prior messages" here as this is just a sanity check.
Co-authored-by: Łukasz Magiera <[email protected]> Co-authored-by: Raúl Kripalani <[email protected]>
…ge-validity fix: stmgr: check message validity before invoking vm
This: - Improves error handling when the FFI is passed invalid messages. - Updates the FVM.
chore: ffi: update the FFI
This reverts commit 2bbd1fb.
fix: stmgr: copy the message before modifying it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging branch for Hyperspace nv20. This merges
release/v1.20.0
intontwk/hyperspace
, and adds actors version 12, nv20 code, backwards compatibility, and migration logic.Upstream PRs
Testing efforts