Nil #10312
Closed
Nil #10312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p track of whether the current line is in a template or generated section, instead of using a separate "state" variable. It also uses the filepath.Walk function instead of filepath.WalkDir and it combines the file reading and checking for file extension into one step. The inTemplate, inGen and templateLines variables are initialized before the for loop, so that they can be used within the loop. The function also directly write the modified contents to the file using ioutil.WriteFile at the end of the loop, instead of using a separate rewrite variable to check if the file needs to be written. This version is more compact, it's using less variables and it's more readable. - The unsanitized input fix is added to check if the "address" form value is a valid address before creating a new address object from it. This prevents potential security issues where an attacker can use an invalid address to exploit the system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps