Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "Eth API: drop support for 'pending' block parameter." #10474

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

raulk
Copy link
Member

@raulk raulk commented Mar 14, 2023

This reverts commit 9412753.

Related Issues

Some tools require pending support on some RPCs, concretely eth_getTransactionCount. This backs out the patch that generally dropped such support, in case we want to restore master to working condition while #10462 is being reviewed.

Proposed Changes

Re-introduce pending block support.

Additional Info

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@raulk raulk requested a review from a team as a code owner March 14, 2023 13:47
@raulk raulk added this to the v1.20.4 milestone Mar 14, 2023
@jennijuju jennijuju modified the milestones: v1.20.4, v1.21.0 Mar 16, 2023
@magik6k magik6k merged commit c0aed3c into master Mar 16, 2023
@magik6k magik6k deleted the raulk/fix-pending-support branch March 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants