feat: miner cli: sectors list upgrade-bounds tool #10923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magik6k
force-pushed
the
feat/sectors-upgradebounds-cli
branch
from
75a56ec to
85a2a9d
Compare
magik6k
force-pushed
the
feat/sectors-upgradebounds-cli
branch
from
85a2a9d to
14f9770
Compare
| }, | ||
| &cli.BoolFlag{ | ||
| Name: "deal-terms", | ||
| Usage: "bucket by how many deal-sectors can start at a given expiration", |
There was a problem hiding this comment.
Not sure I fully understand this. We don't pass in an expiration here so what does this statement mean?
I initially took this to mean filter all deal sectors which can start past a certain time
There was a problem hiding this comment.
Basically when you're packing datacap deals into sectors, the sector expiration must fit two constraints:
- Sector expiration must be larger than deal end - so that the sector is alive for the whole duration of the deal
- Sector expiration must NOT be longer than 90 days after deal expiration - so that you don't get the datacap boost for too much longer than the deal is requesting to be stored for
There was a problem hiding this comment.
(the --deal-terms mode shows how many deals you can accept at a given deal end epoch)
shrenujbansal
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
(Mostly?) Addresses #10908
Proposed Changes
Additional Info
--deal-termsjust shows sectors bucketed by expiration--deal-termsshows how many sectors worth of deals with a given expiration could be accepted into available sectorsChecklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps