Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nv22: lightweight patch to upgrade calibnet #11763

Closed
wants to merge 1 commit into from

Conversation

arajasek
Copy link
Contributor

TODO

  • Add the new actors bundle to the v13 tar.zst, renaming the buggy bundle to have the calibrationnet-13-rc3 suffix
  • Add the new verifreg CIDs
  • Resolve outstanding TODOs about whether any other CIDs change
  • Test (run a dry-run on calibnet)

Related Issues

The calibration test network upgraded to nv22 / actors v13 2 weeks ago. In the time since then, new product requirements have emerged for the upcoming FIP-0083 (see proposals here and here). The current plan is to ship these proposed changes to mainnet AND retroactively apply them to calibnet (which is already running a version of actors v13).

Unfortunately, this is consensus-critical, and so needs a coordinated upgrade on the testnet in order to land the new code. This PR proposes a relatively easy way to achieve this.

Proposed Changes

  • Create a new UpgradeCalibrationDragonFixHeight upgrade that ONLY exists for calibrationnet (disabled for all others)
  • At that height, upgrade the verifreg actor to the new verifreg actor CID (and any other actors that need to change)
  • At that height, upgrade the system actor's manifest to refer to the "new" manifest data
  • Include the patched actors bundle as the v13 bundle for calibrationnet
  • Also, explicitly add the "previous" actors bundle to v13.tar.zst
  • Also, explicitly add the "pervious" verifreg actor info to actorMeta
  • Tweak the "real" v13 migration (that already ran) to upgrade to the "previous" bundle (this is only relevant for syncing calibnet from scratch).

Additional Info

  • Needs to be tested, we'll do that by:
    • simulating this on calibnet
    • actually running this on a butterflynet
  • Could also consider:
    • Doing a "full" upgrade on calibnet with new network / actors version, etc.
    • Leaving calibnet as-is for now, it'll get patched in the next upgrade.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@arajasek
Copy link
Contributor Author

Closing in favour of #11776

@arajasek arajasek closed this Mar 22, 2024
@rjan90 rjan90 deleted the asr/calibnet-dragon-patch branch February 3, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging this pull request may close these issues.

1 participant