Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: actors: manual CC onboarding and proving integration test #12017

Merged
merged 36 commits into from
Jun 6, 2024
Merged

test: actors: manual CC onboarding and proving integration test #12017

merged 36 commits into from
Jun 6, 2024

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented May 20, 2024

WIP, working toward #12009

Starting here with CC onboarding by manually crafting messages with the current flow:

  1. PreCommitSectorBatch2
  2. ProveCommitSectors3
  3. SubmitWindowedPoSt
  4. Confirm by checking miner power

@github-actions GitHub Actions
Copy link

github-actions bot commented May 20, 2024 •
edited
Loading

All checks have completed

❌ Failed Test / Test (itest-sector_import_simple) (pull_request)

@rvagg rvagg force-pushed the rvagg/manual_cc_itest branch from 3780e84 to 0be65d7 Compare May 20, 2024 10:19
aarshkshah1992
aarshkshah1992 reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for my own understanding. But this is really neat that we can prove sectors without using the Miner API.

@rvagg rvagg force-pushed the rvagg/manual_cc_itest branch from 0be65d7 to 6ccdba3 Compare May 21, 2024 05:01
@rvagg rvagg changed the base branch from master to feat/remove-markets-provider May 21, 2024 05:01
@rvagg rvagg marked this pull request as ready for review May 21, 2024 05:02
@rvagg rvagg force-pushed the rvagg/manual_cc_itest branch from 6ccdba3 to 091d6d2 Compare May 21, 2024 08:10
@jennijuju
Copy link
Member

NICE

@aarshkshah1992 aarshkshah1992 mentioned this pull request May 22, 2024
Merged
8 tasks
aarshkshah1992
aarshkshah1992 reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Great stuff Rodd !

itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
itests/manual_onboarding_test.go Outdated Show resolved Hide resolved
@aarshkshah1992 aarshkshah1992 mentioned this pull request May 27, 2024
Closed
8 tasks
@rvagg rvagg force-pushed the rvagg/manual_cc_itest branch from 39fb5cb to ad651df Compare June 3, 2024 09:09
@rvagg
Copy link
Member Author

rvagg commented Jun 3, 2024

Rebased on top of current #12005 which has master merged back in. Also pulled in #12049 as a squashed commit. We can continue iterating from here.

@rvagg rvagg mentioned this pull request Jun 3, 2024
Merged
@rvagg
feat: test: MineBlocksMustPost can watch for >1 miners (#12063)
1d5ed51 
* feat: test: MineBlocksMustPost can watch for >1 miners

* feat: test: wait for both sectors at the end of test

* feat: test: minor manual onboarding test fixups and speed up

* feat: test: handle case where miners have close deadline ends
@rjan90 rjan90 linked an issue Jun 4, 2024 that may be closed by this pull request
[DX Streamline] Lean NI-PoRep integration testing #12009
Closed
Base automatically changed from feat/remove-markets-provider to master June 5, 2024 14:14
aarshkshah1992 and others added 3 commits June 6, 2024 08:07
@aarshkshah1992 @rvagg
Implement snap deals test for manual sector onboarding (#12066)
748c03a 
* changes as per review

* thread safety

* test for snap deals

* remove extraneous change

* Apply suggestions from code review

Co-authored-by: Rod Vagg <[email protected]>

* cancel CC Post after snap deals

---------

Co-authored-by: Rod Vagg <[email protected]>
@aarshkshah1992
Merge remote-tracking branch 'origin/main' into rvagg/manual_cc_itest
119f877
@aarshkshah1992
fix config
a7c76a7
aarshkshah1992
aarshkshah1992 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@aarshkshah1992 aarshkshah1992 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and merging to mastern as discussed offline

@aarshkshah1992
Copy link
Contributor

The test failure is a flaky.

@aarshkshah1992 aarshkshah1992 merged commit 5993841 into master Jun 6, 2024
76 of 77 checks passed
@aarshkshah1992 aarshkshah1992 deleted the rvagg/manual_cc_itest branch June 6, 2024 04:47
@rjan90 rjan90 mentioned this pull request Jun 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjan90 rjan90 rjan90 left review comments

@aarshkshah1992 aarshkshah1992 aarshkshah1992 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DX Streamline] Lean NI-PoRep integration testing
4 participants
@rvagg @jennijuju @aarshkshah1992 @rjan90