chore(events): improve perf for parallel event filter matching #12603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rvagg : is this something you're hoping to see land for 1.31.0? |
|
Yes, but I'd like chainindexer to land first, this can go in separately. Like #12623 I think they deserve separate call-outs in the CHANGELOG. |
59 tasks
rvagg
force-pushed
the
rvagg/parallel-event-filters
branch
2 times, most recently
from
35a9852 to
e01d209
Compare
|
@rvagg should we land this now, given that we are looking at release v1.31.0-rc1 tomorrow? |
rvagg
force-pushed
the
rvagg/parallel-event-filters
branch
from
e01d209 to
db90330
Compare
|
Tagging @masih who would be a good person to review this change. |
masih
approved these changes
Nov 18, 2024
1. Cache address look-ups for the given tipset across filters 2. Run the filters in an errgroup
rvagg
force-pushed
the
rvagg/parallel-event-filters
branch
from
db90330 to
7825f81
Compare
masih
approved these changes
Nov 20, 2024
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked until #12421 is merged and we can do this against master.
I started writing up a
good-first-issueticket for this but it eneded up being easier to write the code than describe what needed doing.boolreturn argument and just useaddress.Undef, I believe there's no case where this is an acceptable valueFilters can be installed via
eth_newFilter,eth_subscribeandSubscribeActorEventsRaw. All filters installed haveCollectEventsrun on them for each new tipset and revert. So this can get expensive if you're an RPC provider who allows users to install these things and watch for live events.