Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): run unit test jobs on arm64 machines additionally #12864
base: master
Are you sure you want to change the base?
feat(ci): run unit test jobs on arm64 machines additionally #12864
Changes from 5 commits
3b77455
a160e23
5b65277
ee46bb0
e2290ef
d9bb59c
35718de
24ca94e
debe0ed
4cb838d
ba81f64
0df6d19
70e7618
7441e78
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it an issue that we aren't caching on self-hosted runners?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we only care about the architecture here really. We use what we cache here on self-hosted runners as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So this job needs to run on x86_64 and arm, which is accomplished by
[ubuntu-latest, ubuntu-24.04-arm]
. Sounds good.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we set an environment variable when it is also referenced below as a param to
gotestsum
? Basically I'm wondering if we should inline this to thegotestsum
call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter much here because we literally execute a script to get these values, but it's a good security practice for some types of workflows so I tend to stick with it in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it - makes sense. I'm good to practice the right behavior here.
Should we adjust this line below to be consistent?