Remove use of exitcode.SysErrInvalidParameters #3184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anorth
commented
Aug 20, 2020
| @@ -342,7 +342,7 @@ func (rt *Runtime) Send(to address.Address, method abi.MethodNum, m vmr.CBORMars | |||
| if m != nil { | |||
| buf := new(bytes.Buffer) | |||
| if err := m.MarshalCBOR(buf); err != nil { | |||
| rt.Abortf(exitcode.SysErrInvalidParameters, "failed to marshal input parameters: %s", err) | |||
| rt.Abortf(exitcode.ErrSerialization, "failed to marshal input parameters: %s", err) | |||
There was a problem hiding this comment.
This was a somewhat legitimate use, but I've changed this to be consistent with our policy elsewhere that parameter/result and state de/serialization is logically part of actor code, and so uses the actor ErrSerialization.
| if addr.Protocol() == address.BLS || addr.Protocol() == address.SECP256K1 { | ||
| return addr, nil | ||
| } | ||
|
|
||
| act, err := state.GetActor(addr) | ||
| if err != nil { | ||
| return address.Undef, aerrors.Newf(exitcode.SysErrInvalidParameters, "failed to find actor: %s", addr) | ||
| return address.Undef, xerrors.Errorf("failed to find actor: %s", addr) |
There was a problem hiding this comment.
These uses didn't make much sense to me. This method is reached only indirectly from actor code; most callers are from outside. Where this is reached, e,g. as part of signature verification, the non-nil error should be propagated to the actor code itself, which will decide to abort. I think this exit code was always ignored.
|
Pulled into #3603 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SysErrInvalidParametersis deprecated, there's no case where it should be used.FYI @raulk