[nv16] improve itest situation and preload manifests in cli #8521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
changed the title
Merged
fix multisig for nv16
raulk
approved these changes
Apr 21, 2022
arajasek
approved these changes
Apr 21, 2022
| @@ -257,7 +257,6 @@ type FVM struct { | |||
| } | |||
|
|
|||
| func NewFVM(ctx context.Context, opts *VMOpts) (*FVM, error) { | |||
| log.Info("using the FVM, this is experimental!") | |||
There was a problem hiding this comment.
Let's leave this log in there for now, if only for us to know which VM is being run (we will def take it out before the final release).
There was a problem hiding this comment.
Merging for now, can add it back later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the correct testing bundles with policy fixes in filecoin-project/builtin-actors#253 and preloads the manifests in the cli so that we have the correct code CIDs in there.
Issues: deal itests appear broken because of deal label mismatches; this needs to be investigated as it might be a bug related to fip27.