export range and small refactor #8640
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please see #8641 |
arajasek
reviewed
May 16, 2022
There was a problem hiding this comment.
Thanks for the contribution! @travisperson's proposal in #8641 is different from this in a few ways:
- the proposal has the method taking TSKs instead of heights
- the proposal requests an option to also include message receipts.
Are these things you would be open to including in this PR?
| @@ -23,6 +23,20 @@ func (cs *ChainStore) UnionStore() bstore.Blockstore { | |||
| } | |||
|
|
|||
| func (cs *ChainStore) Export(ctx context.Context, ts *types.TipSet, inclRecentRoots abi.ChainEpoch, skipOldMsgs bool, w io.Writer) error { | |||
| pleaseVisit := func(b types.BlockHeader) bool { | |||
| return b.Height > ts.Height()-inclRecentRoots | |||
There was a problem hiding this comment.
let's redundantly also check that b.Height isn't greater than ts.Height() (and return false if it is)
|
Closing as outdated. Zen is not a dumbass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes
Hello I want to snapshot some but not a big amount of the chain! It should be in a range
I think this will be a good way to do it Please help me make it possible
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps