[nv16] niceties for development bundle loading #8658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a nicety for development, so that we always load a development bundle to avoid having
to give them distinct names etc. Just call you release "dev" or "dev.xxx..." and put the bundle
in `.lotus/builtin-actors/v8/dev/builting-actors-${network}.{car,sha256sum}` and it will be
unconditionally loaded.
|
unexpected test failures are from github hiccups: |
|
we might want to cache |
|
@vyzo something seems to be broken in GitHub for builtin-actors because even release edit pages return a 404. |
raulk
reviewed
May 16, 2022
There was a problem hiding this comment.
@vyzo It's a weird to rely on a string convention when we have a TOML schema to which we can add properties. I would suggest that if you want to treat a bundle as a development release, you should specify the dev = true key for that bundle in its TOML table.
Also, we should add a path attribute to load the bundle from the local filesystem when it's specified.
|
sure, can do. |
vyzo
changed the title
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: raulk <[email protected]>
Co-authored-by: Aayush Rajasekaran <[email protected]>
[nv16] flexible bundle loading
[nv16] use network bundle names consistent with the network name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some niceties for development bundle loading; see the README.
Related Issues
See #8625