chore: state: add cli to get the manifest & actor cid for network v16 & up #8670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennijuju
changed the title
arajasek
reviewed
May 30, 2022
cli/state.go
Outdated
| _, _ = fmt.Fprintln(tw, "\nActor\tCID\t") | ||
|
|
||
| for _, name := range []string{ | ||
| actors.AccountKey, |
There was a problem hiding this comment.
Can I bug you to make one refactor? Add:
func GetBuiltinActorsKeys() []string {
return []string{
AccountKey,
CronKey,
InitKey,
MarketKey,
MinerKey,
MultisigKey,
PaychKey,
PowerKey,
RewardKey,
SystemKey,
VerifregKey,
}
}
to chain/actors/manifest.go, and use that here (and in chain/actors/manifest.go).
|
|
arajasek
approved these changes
May 30, 2022
chain/actors/manifest.go
Outdated
| @@ -140,3 +129,19 @@ func CanonicalName(name string) string { | |||
|
|
|||
| return name | |||
| } | |||
|
|
|||
| func GetBuiltinActorsKeys() []string { | |||
There was a problem hiding this comment.
Let's put this at the top of the file (right after the keys themselves are defined).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
resolves #8661
Proposed Changes
Additional Info
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>fix: mempool: Introduce a cache for valid signaturesPR type: fix, feat, INTERFACE BREAKING CHANGE, CONSENSUS BREAKING, build, chore, ci, docs,perf, refactor, revert, style, testarea: api, chain, state, vm, data transfer, market, mempool, message, block production, multisig, networking, paychan, proving, sealing, wallet, deps